Added non-strict-mode that allows runs even with failing tests #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, the code looks Ok. It would be better if you could add some tests to test this new feature. |
|
Hi @CarolinaMelendez , thanks for the contribution! Sorry I'm late, I just realized I was not getting notifications on this repo. I agree with @jordanmontt , it would be nice to have a couple of tests on this (otherwise we would be reducing the mutation score of mutalk itself :)). Could you try writing one or two tests that check the the filtering works correctly? Thanks! |
|
I don't think this is moving forward, I'm going to close it. @DurieuxPol do you think this is implementable using test filters? #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my contribution to the issue #28
This implementation added an attribute
Which by default is ´true´ but when set to ´false´ , it will display the information message.
" Your have {#} test(s) that have Errors or Failures. But in Non-Strict-Mode I will filter them "
And run taking in account only the passed tests.